Fixes #246 - Add build directive to docker-compose.yml #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if-fi
pushed a commit
to if-fi/netbox
that referenced
this pull request
Oct 1, 2016
…all-docs Fixes netbox-community#246 - Add build directive to docker-compose.yml
|
@zachmoody, are we ready to reverse this since #471 happened? |
|
I hope to soon. The problem is we're not pushing any untagged images to docker hub so Thinking we'll probably just need to take a pass at the CI script and have it push an untagged version as well, but I haven't had a chance to do it yet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a PR related to #246. This adds a build directive to docker-compose until we can get an image on docker hub to download. Alternatively, we could leave
docker-compose.ymlas is and add a step to the docs todocker build -t digitalocean/netbox .. Whichever works best.