Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2693 - Adds additional colors for cables & roles #2694

Merged

Conversation

DanSheps
Copy link
Member

Fixes: #2693

Adds to the color picker:

  • White
  • Rose
  • Aqua

Additionally matches on the background color white on a label and reverses the font color to black.

@DanSheps DanSheps changed the title Closes #2693 Closes #2693 - Adds additional colors for cables & roles Dec 15, 2018
@jeremystretch
Copy link
Member

@DanSheps The CSS hack is no longer needed; see f4a22e5. If you remove that this should be good to merge.

@jeremystretch jeremystretch added the status: revisions needed This issue requires additional information to be actionable label Dec 19, 2018
@DanSheps
Copy link
Member Author

@jeremystretch Thanks, will do it this week.

* Revert CSS Background Hack
@jeremystretch jeremystretch removed the status: revisions needed This issue requires additional information to be actionable label Jan 3, 2019
@jeremystretch jeremystretch merged commit 6ca045e into netbox-community:develop Jan 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2020
@DanSheps DanSheps deleted the 2693-fiber-cable-colors branch December 18, 2020 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "White" as a cable color
3 participants