Skip to content

Conversation

hSaria
Copy link
Contributor

@hSaria hSaria commented Jan 8, 2020

Fixes: #2113

  • Allow the username and password for NAPALM to be overridden for an API call.
  • Expose NAPALM's optional_args using headers prefixes with NAPALM-. Because they can contain sensitive information like secret, I've opted to use headers.
  • Documented how NetBox works with NAPALM and other odd and ends.

@jeremystretch
Copy link
Member

jeremystretch commented Jan 9, 2020

I'm wondering if we should prefix the header names with X-, e.g. X-NAPALM-USERNAME. Here's some discussion on the topic.

@hellerve
Copy link
Contributor

hellerve commented Jan 9, 2020

I'm wondering if we should prefix the header names with X-, e.g. X-NAPALM-USERNAME. Here's some discussion on the topic.

I’m in favor of prefixing with X-. I’m usually not a fan of in-band signalling like that, but it’s become enough of a standard that I think respecting it makes sense. I understood IETF’s reasoning to deprecate it, but I do not think that those headers should ever be part of the standard, since they’re extremely specific.

@hSaria
Copy link
Contributor Author

hSaria commented Jan 9, 2020

I've changed the prefix to X-NAPALM-

@jeremystretch jeremystretch merged commit 7e0073d into netbox-community:develop Jan 9, 2020
@hSaria hSaria deleted the 2113-napalm-settings branch January 9, 2020 16:57
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamically pass credentials to the Napalm module
3 participants