Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3864: Limit number of related IPs #3869

Closed
wants to merge 2 commits into from
Closed

Fixes #3864: Limit number of related IPs #3869

wants to merge 2 commits into from

Conversation

hSaria
Copy link
Contributor

@hSaria hSaria commented Jan 9, 2020

Fixes: #3864

Limited the related IPs table to 50 entries (currently loads/renders all related IPs). No preference on the number; it just seemed that 50 was good enough for functionality without making the page too long.

@jeremystretch
Copy link
Member

This isn't a resolution for #3864. NetBox should not allow IP addresses to be created with a /0 mask.

@hSaria
Copy link
Contributor Author

hSaria commented Jan 9, 2020

I see. Didn't realise that was the case. Shall I create a separate ticket for the limit bit? It's still possible to create an IP with a subnet mask that makes it related to excessively many IPs.

@jeremystretch
Copy link
Member

Shall I create a separate ticket for the limit bit?

Sure, if you want. Just needs to be called out as a separate issue from the validation bug.

@hSaria
Copy link
Contributor Author

hSaria commented Jan 9, 2020

Sure. I'll raise a new PR for the /0 mask thing.

@hSaria hSaria deleted the 3864-related-ips-limit branch January 9, 2020 14:50
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPAM allows creation of IPAddresses with '0' mask length
2 participants