Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #4255 - Modify script ObjectVars to utilize DynamicModelChoiceField #4258

Merged
merged 6 commits into from
Mar 19, 2020
Merged

Fixes: #4255 - Modify script ObjectVars to utilize DynamicModelChoiceField #4258

merged 6 commits into from
Mar 19, 2020

Conversation

DanSheps
Copy link
Member

@DanSheps DanSheps commented Feb 24, 2020 •
edited
Loading

Fixes: #4255

Adds two new fields that extend their related fields:

  • DynamicObjectVar
  • DynamicMultiObjectVar

Adds tests for those two new fields

@jeremystretch
Copy link
Member

@DanSheps please see my comment on #4255

@DanSheps
Copy link
Member Author

DanSheps commented Mar 2, 2020

@jeremystretch I pushed a new commit, does that look cleaner?

@jeremystretch
Copy link
Member

@DanSheps With #3474 in place, I think all we need to do is tweak the form field.

@DanSheps DanSheps changed the title Fixes: #4255 - Add new script variable types based on dynamic model fields Fixes: #4255 - Modify script ObjectVars to utilize DynamicModelChoiceField Mar 19, 2020
@jeremystretch jeremystretch merged commit 2dff093 into develop Mar 19, 2020
@jeremystretch jeremystretch deleted the 4255-dynamic_object_vars branch March 19, 2020 15:02
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ObjectVar and MultiObjectVar should utilize DynamicModelChoiceField
2 participants
@DanSheps @jeremystretch