Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report inconsistent values when migrating custom field data #5578

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

candlerb
Copy link
Contributor

@candlerb candlerb commented Jan 5, 2021

Fixes: #5573

During migration, if a customfieldvalue references a non-existent object, it bombs out with:

TypeError: 'NoneType' object is not subscriptable

but gives no indication of what data item caused the error.

With this change, the exception still occurs, but the offending data item is printed first (as was already the case for ValueError only).

@jeremystretch jeremystretch merged commit 98983e7 into netbox-community:develop Jan 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception during migration from 2.9.11 to 2.10.2 when customfieldvalue references non-existent object
3 participants