Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #8233 Restrict API key usage by source IP #8865

Closed
wants to merge 11 commits into from
Closed

Closes #8233 Restrict API key usage by source IP #8865

wants to merge 11 commits into from

Conversation

PieterL75
Copy link
Contributor

Implements: #8233

@PieterL75 PieterL75 closed this Mar 14, 2022
@PieterL75 PieterL75 reopened this Mar 14, 2022
@PieterL75 PieterL75 marked this pull request as ready for review March 14, 2022 12:43
@PieterL75 PieterL75 changed the title #8233 Restrict API key usage by source IP Closes #8233 Restrict API key usage by source IP Mar 14, 2022
jeremystretch
jeremystretch requested changes Mar 14, 2022
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great start! Thanks for taking this on.

netbox/users/models.py Outdated Show resolved Hide resolved
docs/configuration/optional-settings.md Outdated Show resolved Hide resolved
netbox/users/models.py Outdated Show resolved Hide resolved
netbox/netbox/api/authentication.py Outdated Show resolved Hide resolved
netbox/users/models.py Outdated Show resolved Hide resolved
PieterL75
PieterL75 commented Mar 14, 2022
View reviewed changes
Copy link
Contributor Author

@PieterL75 PieterL75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating PR with changes

netbox/users/models.py Outdated Show resolved Hide resolved
netbox/users/models.py Outdated Show resolved Hide resolved
netbox/netbox/api/authentication.py Outdated Show resolved Hide resolved
netbox/users/models.py Outdated Show resolved Hide resolved
@PieterL75 PieterL75 requested a review from jeremystretch March 15, 2022 09:56
@PieterL75
Copy link
Contributor Author

Noticed that I'm merging in the master, rather than the develop branch,,,
Canceling this PR

@PieterL75 PieterL75 closed this Mar 15, 2022
@PieterL75 PieterL75 deleted the master branch March 15, 2022 11:11
@PieterL75 PieterL75 restored the master branch March 15, 2022 11:12
@PieterL75 PieterL75 deleted the master branch March 15, 2022 12:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch Awaiting requested review from jeremystretch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PieterL75 @jeremystretch