Possible missed mapping for PowerPorts model (unused PowerPorts model)
#535
Comments
nautics889
added a commit
to nautics889/pynetbox
that referenced
this issue
Mar 21, 2023
Updated models/mapper.py: set `PowerPorts` for "dcim.powerport" in the map-dict.
nautics889
changed the title
PowerPorts modelPowerPorts model (unused PowerPorts model)
nautics889
added a commit
to nautics889/pynetbox
that referenced
this issue
Mar 21, 2023
Updated models/mapper.py: set `PowerPorts` for "dcim.powerport" in the map-dict.
abhi1693
added a commit
that referenced
this issue
Aug 25, 2023
Fix unused `PowerPorts` model (#535)
arthanson
pushed a commit
that referenced
this issue
Aug 25, 2023
* Fix unused `PowerPorts` model (#535) Updated models/mapper.py: set `PowerPorts` for "dcim.powerport" in the map-dict. * migrate from pkg_resources to importlib * adds core app * adds endpoints added in 3.5 * adds support for 3.5 * lint fixes * updates openapi tests * adds testing for 3.4 and 3.5 * updates pytest.skip * updates docker tags for testing * fixes superuser account creation for testing * fixed requirements * updates the docstring for render-config endpoint * removes extra semicolon from content type value * migrate from pkg_resources to importlib * adds core app * adds endpoints added in 3.5 * adds support for 3.5 * lint fixes * updates openapi tests * adds testing for 3.4 and 3.5 * updates pytest.skip * updates docker tags for testing * fixes superuser account creation for testing * fixed requirements * updates the docstring for render-config endpoint * removes extra semicolon from content type value --------- Co-authored-by: nautics889 <cyberukr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've noticed there is an unused import of
PowerPortsmodel in pynetbox/models/mapper.py module:However there's an item in the mapper-dict named
"dcim.consoleport". Perharps there should bePowerPorts, but there isConsolePortsinstead.Also
ConsolePortsis mapped with"dcim.consoleports"key.So currently we map two different keys to
ConsolePortsmodel:"dcim.consoleport"and"dcim.powerport".Is that logic correct?
The text was updated successfully, but these errors were encountered: