Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API version for Netbox version > 4.x #616

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

btriller
Copy link
Contributor

@btriller btriller commented May 27, 2024

fixes #612

@terraflubb
Copy link

terraflubb commented Jun 10, 2024

I think this is a nicer solution to #612 than mine as it captures more potential failure cases (#613 won't solve the "I don't have auth, just curious what version, which isn't a secret anyway"), plus it's smaller. But I'll take whatever I can get at this point.

But FYI @btriller , the workflow that does the linting (which requires approval and who knows when that will happen 😢) will fail as I discovered. It looks like this check was added without first being executed on the code base.

If you cherry-pick this commit from my PR: 6036016

It will add all the newlines needed to pass the linting.

Speaking from experience, it would be disappointing if this finally got its workflow approved only to be stalled by another month for reasons outside your control.

@jeffgdotorg jeffgdotorg self-assigned this Jul 2, 2024
@jeffgdotorg jeffgdotorg self-requested a review July 2, 2024 20:45
Copy link
Contributor

@jeffgdotorg jeffgdotorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't get much cleaner or more narrowly targeted than this. Thanks.

@jeffgdotorg jeffgdotorg merged commit 9dc54a9 into netbox-community:master Jul 2, 2024
@btriller btriller deleted the api-version-4.x branch July 2, 2024 21:44
@terraflubb
Copy link

❤️ Thank you so much for jumping in @jeffgdotorg !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth fails getting API version with Netbox 4.0.0
3 participants