Draft: Speed improvements

pynetbox/core/app.py

@@ -41,6 +41,7 @@ def __init__(self, api, name):
         self.api = api
         self.name = name
         self._setmodel()
+        self._cached_endpoints = {}
 
     models = {
         "dcim": dcim,
@@ -63,7 +64,11 @@ def __setstate__(self, d):
         self._setmodel()
 
     def __getattr__(self, name):
-        return Endpoint(self.api, self, name, model=self.model)
+        if name not in self._cached_endpoints:
+            self._cached_endpoints[name] = Endpoint(
+                self.api, self, name, model=self.model
+            )
+        return self._cached_endpoints[name]
 
     def config(self):
         """Returns config response from app
@@ -103,6 +108,7 @@ class PluginsApp:
 
     def __init__(self, api):
         self.api = api
+        self._cached_apps = {}
 
     def __getstate__(self):
         return self.__dict__
@@ -111,7 +117,11 @@ def __setstate__(self, d):
         self.__dict__.update(d)
 
     def __getattr__(self, name):
-        return App(self.api, "plugins/{}".format(name.replace("_", "-")))
+        if name not in self._cached_apps:
+            self._cached_apps[name] = App(
+                self.api, "plugins/{}".format(name.replace("_", "-"))
+            )
+        return self._cached_apps[name]
 
     def installed_plugins(self):
         """Returns raw response with installed plugins

pynetbox/core/endpoint.py

@@ -20,6 +20,37 @@
 RESERVED_KWARGS = ()
 
 
+class CachedRecordRegistry:
+    """
+    A cache for Record objects.
+    """
+
+    def __init__(self):
+        self._cache = {}
+        self._hit = 0
+        self._miss = 0
+
+    def get(self, object_type, key):
+        """
+        Retrieves a record from the cache
+        """
+        if not (object_cache := self._cache.get(object_type)):
+            return None
+        if object := object_cache.get(key, None):
+            self._hit += 1
+            return object
+        self._miss += 1
+        return None
+
+    def set(self, object_type, key, value):
+        """
+        Stores a record in the cache
+        """
+        if object_type not in self._cache:
+            self._cache[object_type] = {}
+        self._cache[object_type][key] = value
+
+
 class Endpoint:
     """Represent actions available on endpoints in the Netbox API.
 
@@ -42,8 +73,8 @@ class Endpoint:
     """
 
     def __init__(self, api, app, name, model=None):
-        self.return_obj = self._lookup_ret_obj(name, model)
         self.name = name.replace("_", "-")
+        self.return_obj = self._lookup_ret_obj(model)
         self.api = api
         self.base_url = api.base_url
         self.token = api.token
@@ -53,8 +84,12 @@ def __init__(self, api, app, name, model=None):
             endpoint=self.name,
         )
         self._choices = None
+        self._init_cache()
 
-    def _lookup_ret_obj(self, name, model):
+    def _init_cache(self):
+        self._cache = CachedRecordRegistry()
+
+    def _lookup_ret_obj(self, model):
         """Loads unique Response objects.
 
         This method loads a unique response object for an endpoint if
@@ -67,7 +102,7 @@ def _lookup_ret_obj(self, name, model):
         :Returns: Record (obj)
         """
         if model:
-            name = name.title().replace("_", "")
+            name = self.name.title().replace("-", "")
             ret = getattr(model, name, Record)
         else:
             ret = Record
@@ -636,8 +671,8 @@ def count(self, *args, **kwargs):
 
         if any(i in RESERVED_KWARGS for i in kwargs):
             raise ValueError(
-                "A reserved {} kwarg was passed. Please remove it "
-                "try again.".format(RESERVED_KWARGS)
+                "A reserved kwarg was passed ({}). Please remove it "
+                "and try again.".format(RESERVED_KWARGS)
             )
 
         ret = Request(