Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OBS-7 - diode-sdk-go with distributor client bare bones #11

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

mfiedorowicz
Copy link
Member

No description provided.

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz mfiedorowicz self-assigned this Feb 7, 2024
@mfiedorowicz mfiedorowicz requested a review from natm as a code owner February 7, 2024 10:38
Copy link

linear bot commented Feb 7, 2024

OBS-7 Create diode-sdk-go bare bones

We need to create diode sdk written in Go based on code generated from proto files.

Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 2 important findings in this PR that you should review.
The findings are detailed below as separate comments.
It’s highly recommended that you fix these security issues before merge.

diode-sdk-go/diode/v1/distributor/client.go Show resolved Hide resolved
diode-sdk-go/diode/v1/distributor/client.go Show resolved Hide resolved
Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 1 important finding in this PR that you should review.
The finding is detailed as a comment.
It’s highly recommended that you fix this security issue before merge.

Until now, you ignored/fixed 1 finding.

@mfiedorowicz mfiedorowicz merged commit 50f4778 into develop Feb 7, 2024
9 checks passed
@mfiedorowicz mfiedorowicz deleted the OBS-7-diode-sdk-go-bare-bones branch February 7, 2024 10:45
@orb-ci
Copy link

orb-ci commented Feb 14, 2024

🎉 This PR is included in version diode-sdk-go-v1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants