Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add virtualization object types support #155

Merged
merged 22 commits into from
Aug 30, 2024
Merged

feat: add virtualization object types support #155

merged 22 commits into from
Aug 30, 2024

Conversation

leoparente
Copy link
Contributor

No description provided.

@leoparente leoparente self-assigned this Aug 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 13, 2024 •
edited
Loading

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.29s github.com/netboxlabs/diode/diode-server/ingester 4.9% 9 0 0
🟢 PASS 0.02s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.65s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 6.8% 40 0 0
🟢 PASS 1.58s github.com/netboxlabs/diode/diode-server/reconciler 8.2% 27 0 0
🟢 PASS 1.41s github.com/netboxlabs/diode/diode-server/reconciler/changeset 78.6% 78 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 80.3%

@leoparente leoparente marked this pull request as ready for review August 21, 2024 19:16
@mfiedorowicz mfiedorowicz mentioned this pull request Aug 23, 2024
Merged
@leoparente leoparente mentioned this pull request Aug 26, 2024
Merged
mfiedorowicz
mfiedorowicz approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leoparente, great work 🙇

mfiedorowicz
mfiedorowicz reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more fix needed 🙏

mfiedorowicz
mfiedorowicz approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

mfiedorowicz
mfiedorowicz requested changes Aug 30, 2024
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One fix needed to enable cluster type entity ingestion

mfiedorowicz
mfiedorowicz reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of issues discovered while testing Go SDK with virtualization types support.

@mfiedorowicz mfiedorowicz mentioned this pull request Aug 30, 2024
Merged
@leoparente @mfiedorowicz
Apply suggestions from code review
4da676d 
Co-authored-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@leoparente leoparente merged commit be4fd4d into develop Aug 30, 2024
6 checks passed
@leoparente leoparente deleted the feat/OBS-495-add-vm-object-type-support branch August 30, 2024 15:50
@orb-ci
Copy link

orb-ci commented Sep 5, 2024

🎉 This PR is included in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@orb-ci orb-ci added the released label Sep 5, 2024
@orb-ci
Copy link

orb-ci commented Sep 5, 2024

🎉 This PR is included in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

@natm natm Awaiting requested review from natm

Assignees

@leoparente leoparente

Labels
diode-proto diode-reconciler diode-server go internal released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leoparente @orb-ci @mfiedorowicz