Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add authz for retrieving ingestion logs #165

Merged
merged 3 commits into from
Sep 5, 2024
Merged

feat: add authz for retrieving ingestion logs #165

merged 3 commits into from
Sep 5, 2024

Conversation

mfiedorowicz
Copy link
Member

No description provided.

@mfiedorowicz
feat: add authz for retrieving ingestion logs
8a10924 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
tidy up error messages
812a068 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
naming consistency
ea1c5e1 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz mfiedorowicz self-assigned this Sep 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.23s github.com/netboxlabs/diode/diode-server/ingester 4.6% 9 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.53s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 6.8% 40 0 0
🟢 PASS 1.42s github.com/netboxlabs/diode/diode-server/reconciler 7.8% 36 0 0
🟢 PASS 1.40s github.com/netboxlabs/diode/diode-server/reconciler/changeset 78.3% 81 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 79.9%

leoparente
leoparente approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work! LGTM

@mfiedorowicz mfiedorowicz merged commit c170a04 into develop Sep 5, 2024
6 checks passed
@mfiedorowicz mfiedorowicz deleted the feat/reconciler-svc-ingestion-logs-authz branch September 5, 2024 19:56
@orb-ci
Copy link

orb-ci commented Sep 26, 2024

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@orb-ci
Copy link

orb-ci commented Sep 26, 2024

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoparente leoparente leoparente approved these changes

@natm natm Awaiting requested review from natm

Assignees

@mfiedorowicz mfiedorowicz

Labels
diode-reconciler diode-server go released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfiedorowicz @orb-ci @leoparente