Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ingestion logs pagination and metrics adjustments #171

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

mfiedorowicz
Copy link
Member

  • introduce id field for ingestion log, containing sortable ksuid
  • fix ingestion metrics collection
  • adjust FT index with id sortable text field
  • adjust pagination using offset

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Copy link

github-actions bot commented Sep 17, 2024

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.21s github.com/netboxlabs/diode/diode-server/ingester 4.5% 9 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.56s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 3.4% 40 0 0
🟢 PASS 1.43s github.com/netboxlabs/diode/diode-server/reconciler 11.8% 57 0 0
🟢 PASS 1.51s github.com/netboxlabs/diode/diode-server/reconciler/changeset 32.3% 81 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 80.0%

Copy link
Contributor

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM!

…fset)

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz mfiedorowicz merged commit 9983fcf into develop Sep 18, 2024
7 checks passed
@mfiedorowicz mfiedorowicz deleted the ingestion-logs-pagination-metrics-adjustments branch September 18, 2024 09:54
@orb-ci
Copy link

orb-ci commented Sep 26, 2024

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@orb-ci
Copy link

orb-ci commented Sep 26, 2024

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants