Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable gofumpt lint #204

Merged
merged 5 commits into from
Dec 16, 2024
Merged

chore: enable gofumpt lint #204

merged 5 commits into from
Dec 16, 2024

Conversation

ltucker
Copy link
Contributor

@ltucker ltucker commented Dec 16, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/dbstore/postgres 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/gen/dbstore/postgres 0.0% 0 0 0
🟢 PASS 1.23s github.com/netboxlabs/diode/diode-server/ingester 71.2% 9 0 0
🟢 PASS 1.05s github.com/netboxlabs/diode/diode-server/migrator 68.2% 4 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.69s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 78.9% 42 0 0
🟢 PASS 1.47s github.com/netboxlabs/diode/diode-server/reconciler 85.0% 64 0 0
🟢 PASS 1.09s github.com/netboxlabs/diode/diode-server/reconciler/applier 88.9% 1 0 0
🟢 PASS 1.36s github.com/netboxlabs/diode/diode-server/reconciler/differ 80.9% 81 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 79.5%

@ltucker ltucker changed the title Enable gofumpt lint chore: enable gofumpt lint Dec 16, 2024
@ltucker
Copy link
Contributor Author

ltucker commented Dec 16, 2024 •
edited
Loading

The linter output in github is not very specific... basically just tells you if you're in violation or not Error: File is not `gofumpt`-ed (gofumpt) (though usually near the violation at least).

I added a target to fix lint suggestions in the local Makefile as well and allowed it to clean existing violations.

@ltucker ltucker marked this pull request as ready for review December 16, 2024 19:42
mfiedorowicz
mfiedorowicz approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ltucker ltucker merged commit 6ea3df5 into develop Dec 16, 2024
3 checks passed
@ltucker ltucker deleted the gofumpt_lint branch December 16, 2024 19:49
mfiedorowicz pushed a commit that referenced this pull request Dec 17, 2024
@ltucker @mfiedorowicz
chore: enable gofumpt lint (#204)
78d16a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

@leoparente leoparente Awaiting requested review from leoparente leoparente is a code owner

Assignees
No one assigned
Labels
diode-ingester diode-reconciler diode-server go internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltucker @mfiedorowicz