Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small refactoring of ingestion processing #213

Merged
merged 1 commit into from
Dec 30, 2024
Merged

small refactoring of ingestion processing #213

merged 1 commit into from
Dec 30, 2024

Conversation

ltucker
Copy link
Contributor

@ltucker ltucker commented Dec 30, 2024

  • pulls out ApplyChangeSet logic from ingestion processor
  • fixes some inconsistencies in logging
  • makes a few things public that were private

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 30, 2024 •
edited
Loading

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 0.00s github.com/netboxlabs/diode/diode-server/dbstore/postgres 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/gen/dbstore/postgres 0.0% 0 0 0
🟢 PASS 1.26s github.com/netboxlabs/diode/diode-server/ingester 71.2% 9 0 0
🟢 PASS 1.05s github.com/netboxlabs/diode/diode-server/migrator 68.2% 4 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.61s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 78.9% 42 0 0
🟢 PASS 1.46s github.com/netboxlabs/diode/diode-server/reconciler 83.2% 49 0 0
🟢 PASS 1.09s github.com/netboxlabs/diode/diode-server/reconciler/applier 81.8% 1 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/reconciler/changeset 0.0% 0 0 0
🟢 PASS 1.30s github.com/netboxlabs/diode/diode-server/reconciler/differ 80.3% 81 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 74.9%

@ltucker ltucker force-pushed the ingestion_refactoring_2 branch from a753200 to 664f4dd Compare December 30, 2024 19:15
@ltucker ltucker force-pushed the ingestion_refactoring_2 branch from 664f4dd to 58a31a3 Compare December 30, 2024 19:15
@ltucker ltucker marked this pull request as ready for review December 30, 2024 19:18
mfiedorowicz
mfiedorowicz approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ltucker ltucker merged commit ff13ccc into feat-postgres-implementation-and-enhancements Dec 30, 2024
3 checks passed
@ltucker ltucker deleted the ingestion_refactoring_2 branch December 30, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

@leoparente leoparente Awaiting requested review from leoparente leoparente is a code owner

Assignees
No one assigned
Labels
diode-reconciler diode-server go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltucker @mfiedorowicz