Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a placeholder changeset if diffing fails #240

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

ltucker
Copy link
Contributor

@ltucker ltucker commented Jan 24, 2025

improves information available when an ingestion log that failed diffing is presented as a deviation

if diffing fails, an empty changeset with an appropriate deviation name and branch are created.

improves information available when presented as a deviation
Copy link

github-actions bot commented Jan 24, 2025

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/dbstore/postgres 0.0% 0 0 0
🟢 PASS 1.22s github.com/netboxlabs/diode/diode-server/ingester 75.4% 9 0 0
🟢 PASS 1.06s github.com/netboxlabs/diode/diode-server/migrator 70.4% 4 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.71s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 78.9% 42 0 0
🟢 PASS 1.42s github.com/netboxlabs/diode/diode-server/reconciler 77.1% 43 0 0
🟢 PASS 1.09s github.com/netboxlabs/diode/diode-server/reconciler/applier 81.8% 1 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/reconciler/changeset 0.0% 0 0 0
🟢 PASS 1.34s github.com/netboxlabs/diode/diode-server/reconciler/differ 74.2% 92 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 71.7%

@ltucker ltucker marked this pull request as ready for review January 24, 2025 19:47
@ltucker ltucker merged commit 3f44ac7 into feat-postgres-implementation-and-enhancements Jan 24, 2025
3 checks passed
@ltucker ltucker deleted the failed_diff branch January 24, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants