fix: OBS-441 - reconciler: use manufacturer provided with platform + improvements #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mfiedorowicz
commented
May 22, 2024
•
mfiedorowicz
commented
- reconciler: use manufacturer provided with platform
- diode-sdk-python: populate manufacturer provided in the root level of the Device, Interface and IPAddress envelopes if not provided explicitly within DeviceType, Platform envelopes
- integration tests to use SDK wrappers of generated protobuf messages
…nested messages if empty Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
…e and device type Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
OBS-441 🐞 reconciler: incorrect manufacturer for device type
When ingested device type is provided with manufacturer, instead of using existing manufacturer (object state retrieved from diode-netbox-plugin API) we attempt to create a new manufacturer with same values as existing one. Reported via slack: https://netboxlabs.slack.com/archives/C06BT2NLF9A/p1716235254021569 |
github-actions
bot
added
go
python
diode-sdk-python
diode-server
diode-reconciler
labels
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.