Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #138: Fix the ID column of the change diffs table #147

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fixes #138: Fix the ID column of the change diffs table #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions netbox_branching/tables/tables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ def render_is_active(self, value):


class ChangeDiffTable(NetBoxTable):
name = tables.Column(
verbose_name=_('Name'),
linkify=True
# TODO: Revert to the default "id" column when a detail view for ChangeDiff is implemented
id = tables.Column(
verbose_name=_('ID')
)
branch = tables.Column(
verbose_name=_('Branch'),
Expand Down Expand Up @@ -122,8 +122,8 @@ class ChangeDiffTable(NetBoxTable):
class Meta(NetBoxTable.Meta):
model = ChangeDiff
fields = (
'branch', 'object_type', 'object', 'action', 'conflicts', 'original_diff', 'modified_diff', 'current_diff',
'last_updated', 'actions',
'id', 'branch', 'object_type', 'object', 'action', 'conflicts', 'original_diff', 'modified_diff',
'current_diff', 'last_updated', 'actions',
)
default_columns = ('branch', 'object', 'action', 'conflicts', 'original_diff', 'modified_diff', 'current_diff')

Expand Down