-
Notifications
You must be signed in to change notification settings - Fork 3
Closes: #282 - Add handling for max_custom_object_types config option (and configuration.md) #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jeremystretch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add max_custom_object_types to default_settings in the AppConfig as well, as a supplementary means of documentation.
We might also want to set a default limit (e.g. 100) for sanity.
jeremystretch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to lower the default maximum to 50.
jeremystretch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to lower the default maximum to 50.
Closes: #282
Enables configuration of a
max_custom_object_typessetting:Attempting to create more than this number of Custom Object Types will raise a ValidationError (this is done via
cleanat the model level, so this will work the same via the UI or API).