refactor(classic): Dispatch global actions with undefined cursor to occur on a viable parent level #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccur on a viable parent level
Pull Request Test Coverage Report for Build 462
💛 - Coveralls |
ognen
requested changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We briefly discussed this with @ognen.
We only want to do this for global actions that are being dispatched. There are some cases where the result of
.query(path)returnsundefineddue to no cursor being present at that path anymore. This causes the dispatch to fizzle out becauseactions.atCursorwill fail at this line, when trying to access_keyPathfromundefined.Anyway, I opened this PR in order to discuss this first and see if we can tackle this problem another way.