-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JSR 303 validation groups #31
Comments
Sure, sounds reasonable. The validation group name is just a string but I wouldn't include the |
Great! Will have a go at this. It might take several weeks calendar time depending on our backlog prioritization. |
In our project we are currently using versions of valdr-bean-validation and valdr frontend containing this modification. I would appreciate if you took the time to look into merging these PRs, as we would like to get back to using the off the shelf valdr. |
Your bump was due, Tero, I agree. Last night I made a mental note to talk to the valdr maintainers to analyze your PR. Once that one is approved I'll merge the Java support as well. |
We need to validate an object of class A differently in different situations, and we use validation groups for that in the backend.
Now we would like to use valdr in the frontend, but there is no support for validation groups.
We are planning to implement support for validation groups in our own copy of valdr-bean-validation, but would ultimately like to see that feature pulled into valdr-bean-validation.
Our rough plan is as follows:
My question is: would you consider a PR on this feature? If so, is the above approach ok?
The text was updated successfully, but these errors were encountered: