-
Notifications
You must be signed in to change notification settings - Fork 0
DRAFT: Add Terraform Deployment #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
benloh
wants to merge
21
commits into
dev
Choose a base branch
from
deploy-terraform
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of `node nc-multiplex.js`
Keep in case we need to restore this later
…ver `--port=8080`
…r reverse proxy SSL Use with netcreate-deploy-do repo to provision droplets with ansible
…an just through 4030) in case PROCES_MAX changes.
Feature: Deploy & SSL
Update README with how list of databases is retained across restarts
To Do
|
No active installs that will get borked if the main repo changes.
…On Fri, Sep 5, 2025 at 12:39 PM benloh ***@***.***> wrote:
*benloh* left a comment (netcreateorg/nc-multiplex#19)
<#19 (comment)>
To Do
- Confirm that it's safe to update the dev and production branches --
does Kalani have any active installs that might get inadvertently updated?
- Merge #17 <#17>
first
- Then merge this (deploy-terraform) into dev
- Then merge dev into production
- Then tag v1.1.0
—
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACKL4NCHJKFIEQDOUBPX5ED3RHDGRAVCNFSM6AAAAACBEZDMLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENJZGI2DENJXGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
active graphs, templates, lokis, backups, logs
Download Data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform/Ansible Deployment Features
This PR adds support for running
nc-multiplex
on DigitalOcean droplets with SSL (to support subdomain mapping, e.g.https://red.netcreate.app
) via a CI/CD workflow.nc-terraform-cloud-mgr
repo for details.New Features
Details
Supporting subdomains and SSL with
nc-multiplex
requires the addition of an NGINX reverse proxy server that can route websocket traffic to opened graphs.In order to support HTTPS on DigitalOcean droplets, web sockets needed to also be secure. If https is detected in the URL, then websocket traffic is now directed to wss:///ws_port/ instead of ws://:.
This requires corresponding changes in the
netcreate-itest
deploy-terraform
branch.nc-multiplex
manageAdmin manage requests are sent via SSL to
nc-multiplex
via port 8080.Basic graph request
Loading a graph uses a similar mechanism, mapping a specific graph (e.g.
demo
) to a specific port...Graph websocket request
..while websocket requests for a specific graph (e.g.
demo
) are routed via a url on port 443 (matching/ws-port/xxxx
) to the websocket port running onnetcreate-itest
.New Branching Strategy
deploy-terraform
branch will be a new branch that is used to deploync-multiplex
to DigitalOcean droplets via thenc-terraform-cloud-mgr
andnc-app-config
repos. It is a protected branch.nc-terraform-cloud-mgr
andnc-app-config
will pull from thedeploy-terraform
branch -- this insures that automated workflows will always function.deploy-terraform
needs to be synced withmain
anddev
(eventually)deploy-terraform
needs to ALWAYS be runnable -- you don't know when droplets might be updated.To Do
dev
so that deployment updates are available in the working branches. (This PR should remain a DRAFT until we are ready to merge intodev
).