Gracefully handle server disconnect in client

[jdanish]

It looks like this is now much more robust. However, the warning message is not appearing (I noticed it in the code when I pulled).

[benloh]

This is where things get complicated...

Just making sure:

1. Are you running netcreate-2018 standalone or with nc-multiplex?
2. How are you forcing the disconnect?

Here's what I do:

1. Run netcreate-2018 via npm run dev (NOT nc-multiplex)
2. Connect to localhost:3000
3. Ctrl-c in the terminal to stop the server.
4. "Server disconnected" message should appear.

I still need to test all the changes I made in the last two days against nc-multplex.

[benloh]

OK, just tested against nc-multiplex and this should work.

To test there, remember you have to repackage netcreate after the pull.

1. cd nc-multiplex/netcreate-2018/build
2. git pull
3. npm run package
4. cd nc-multiplex
5. node nc-multiplex.js

[jdanish]

I was running multiplex and did repackage. I was testing by connecting and then turning off wi-fi to emulate network problems. On the client it seemed to “know” not to allow editing but didn’t give a warning. I’ll retry with most recent build tonight and follow up. Thanks!

…

---- (from my iPhone) Joshua Danish http://www.joshuadanish.com

On Aug 7, 2020, at 7:15 PM, benloh ***@***.***> wrote:  OK, just tested against nc-multiplex and this should work. To test there, remember you have to repackage netcreate after the pull. cd nc-multiplex/netcreate-2018 git pull npm run package cd nc-multiplex node nc-multiplex.js — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[jdanish]

I have confirmed that if I control-c on the server, this works as you described. However, if I kill the network at the client-side, it doesn't seem to know the connection was lost in terms of reporting an error. I am guessing that because edit requests attempt to lock at the server, it is not allowing that to happen so it's better than before in that you can't make an edit that you think is going through, but ideally, the behavior would be identical regardless of what severed the connection.

[benloh]

Ah, got it. So I believe MEME doesn't do detection at that level either. It's only checking whether the screen capture extension is installed. It looks like webpack might be giving us an error event in MEME that we can use. But NetCreate doesn't. I'd have to look into how easy this is to implement. The server disconnect functionality I put in was built on top of existing server handshaking protocols that we had already built into the system.

…

On Fri, Aug 7, 2020 at 5:21 PM Joshua Danish ***@***.***> wrote: I have confirmed that if I control-c on the server, this works as you described. However, if I kill the network at the client-side, it doesn't seem to know the connection was lost in terms of reporting an error. I am guessing that because edit requests attempt to lock at the server, it is not allowing that to happen so it's better than before in that you can't make an edit that you *think* is going through, but ideally, the behavior would be identical regardless of what severed the connection. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#106 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKWRMMNTKYIGVRJWI462ZDR7SLBPANCNFSM4PX72ASA> .

[jdanish]

Ok, why don’t we put this as a lower priority for now and we will test to see if losing network connectivity causes any major issues anymore and then we can target those. My early tests made it seem ok.

[benloh]

TO DO

Before closing this...

• Test with nc-multiplex
• Remove "Server Disconnect" if connection is restored? -- What if you miss one heartbeat due to network hiccup? And the server comes back? Is it possible to restore the connection?
• Edge "Edit" and "Delete" buttons are still shown on lockout.
• Make sure STANDALONE mode still works!!! "Server Disconnect" message might be shown.

[benloh]

@jdanish Since I was already on this, it was easier to finish it now than to spin it back up again. Please test the pull request: #107

Especially STANDALONE mode, which I haven't tested yet.

As for restoring after the connection is restored, it's probably better for everyone if we just get users to reload. Otherwise we'll have a lot of hairy network conflicts we have to resolve.

[jdanish]

@benloh Will check. Did you see Kalani's note (no clue where it was now, or maybe it was mine) about making the disconnect error non-modal? So for students with bad internet they can keep browsing the graph and just can't edit it?

[benloh]

@jdanish Yes, a non-modal disconnect message is in my queue next.

[benloh]

Fixed with 8648e3d

@jdanish @kalanicraig feel free to adjust the message as you see fit. Right now it says: "Server Disconnected! Your changes will not be saved! Please contact your administrator to restart the graph."

The app will now prevent any data edits when disconnected.

[jdanish]

Thanks @benloh

Can you confirm, the user will need to reload, right? If so I'll put that in the message. Though we won't want them to reload if they are intentionally offline (that can be communicated elsewhere).

Thanks!