-
Notifications
You must be signed in to change notification settings - Fork 3
Feature: Focus #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature: Focus #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dge.id`. Addresses #267.
… filtering views. (REVIEW: This can be a problem for the `Filter/Hide` filter, which is not supposed to recalculate. But we are assuming that we are removing that feature)
Two quick notes:
|
… between filter modes.
jdanish
approved these changes
Jun 3, 2023
@benloh ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Merge #264 First!
This is a rough first pass at the focus feature.
It made most sense as another temporary "View" modification tied to Filters, so I added it to the panel formerly known as "Filters" but is now called "Views".
To Test
There may very well be some algorithm issues with the way I'm crawling the network, so please verify that it does what you expect.
There may also be some weird interim states if you're going back and forth between the tables and the filters.
I've also attached a sample project for testing. Just unzip and put it in
netcreate-2023/build/runtime
focus.zip