Skip to content

Conversation

benloh
Copy link
Collaborator

@benloh benloh commented Jun 1, 2023

NOTE: Merge #264 First!

This is a rough first pass at the focus feature.

It made most sense as another temporary "View" modification tied to Filters, so I added it to the panel formerly known as "Filters" but is now called "Views".

To Test

  1. Quit and restart the server.
  2. Select a node
  3. Click on "Views" panel
  4. Click on the "Focus" tab
  5. The graph should show your selected node and one degree of separation from that node
  6. Use the stepper buttons to move the range up and down.
  7. You should be able to increase it to any number
  8. You should not be able to able to decrease it below 1
  9. You should be able to use backspace to delete the range value and type in a new value
  10. If you type in a 0 or negative value, the input field will remain blank
  11. Try different range values to make sure the selection range is correct.
  12. Open the Nodes Table => The nodes listed in the table should match the visible nodes, any nodes not graph should be removed.
  13. Open the Edges Table => The edges should match
  14. Clicking "Clear Filters" should restore all the nodes

There may very well be some algorithm issues with the way I'm crawling the network, so please verify that it does what you expect.
There may also be some weird interim states if you're going back and forth between the tables and the filters.

I've also attached a sample project for testing. Just unzip and put it in netcreate-2023/build/runtime
focus.zip

@benloh benloh added this to the Spring 2024 milestone Jun 1, 2023
@benloh benloh requested a review from jdanish June 1, 2023 22:50
@benloh
Copy link
Collaborator Author

benloh commented Jun 1, 2023

Two quick notes:

  • Focus always removes. The Hiding functionality is, well, hidden at the moment pending in decisions in Rename Filter functions #263
  • Right now the View/filter features work independently of each other. I think if we wanted to combine them we might want to rethink the interface. So it isn't easy to have Highlight/Collapse and Focus on at the same time from a UI-perspective. The filter logic however is quite capable of handling that. So if we can figure out a good UI solution we should be able to implement that relatively easily.

@jdanish
Copy link
Collaborator

jdanish commented Jun 3, 2023

@benloh ready for merge

@benloh benloh merged commit 2cc0b92 into dev Jun 3, 2023
@benloh benloh deleted the dev-bl/focus branch June 3, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants