-
Notifications
You must be signed in to change notification settings - Fork 3
Spring Features: Zoom, Delete, Others #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o deletes or re-links edges.
…. An expert interface for deleting and relinking.
… Node ID didn't match data. Node IDs are integers.
… would reset AutoComplete field target.
…ted inactive mode during render. (Field would show as disabled during Edge Edits when it should be static)
…ing a second node and cleared if editing is canceled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a number of features slated for the Spring test. (The numbers correspond to the request items in the Next Steps Google Doc
5. Zoom Buttons
There is now a "+" zoom in, "•" zoom reset, and "-" zoom out button.
4. Edge Highlight
If you mouseover a node, the other edges will now fade out leaving only the currently moused-over edges displayed. When you change nodes, there is a slow transition to the new highlight so you can better detect the shift.
7a. Degrees display in Nodes Table
The Nodes Table now shows "Degrees". You can customize the table header using the template.
10. Nodes with same title
If you try to add a new node that matches an existing title, you will get a warning and given the choice of viewing the existing node or continuing to enter the node. Clicking "View Existing" will open up the existing node. Clicking "Continue" will let you continue to create a duplicate node. The duplicate node label warning is case insensitive. The duplicate node warning only appears if you're adding a new node, not editing an existing node.
The Duplicate Label warning is now displayed to the side of the node.
13a. Lock Table Buttons and Header
There is now a tab bar that lets you select between the Graph, the Nodes Table, Edges Table, and Help. The header bar is now also locked in place and doesn't scroll. Clicking on the tab headings a second time will toggle the tab (hiding/showing). Cursor shows as a pointer for the tabs.
13b. Resize Table Height
There is now a gray dragger bar that you can use to resize the tables. Both tables share the same size. The bar goes away if you choose Graph or Help.
12. Delete Button
You can now delete a node by selecting it and clicking the "Delete" button. If you simply click "Delete" the node and any related edges will be deleted.
There is an optional field to enter a replacement ID node. Enter the iD number of the node you want to remap the deleted node to. The Replacement Node ID (for re-linking a deleted node) is checked to make sure it's valid. You can still delete and replace with an invalid ID, but now at least you get a warning. (We could disable the Delete button if the node ID is invalid, but then we get into weird state problems if you change your mind and don't want to use a Replacement Node ID). It's a little clunky, but I assume we'll fix this with the modal dialog approach later.
The "Delete" button is only shown if you're on localhost. Any computer using a different url (e.g. a student computer on the network) will not see the Delete button.
Other Items / New Requests
See also, the discussion in basecamp