hotfix-for-234b: Digital Ocean NPM Script Fixes #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d missing @build-ursys to `npm run package` These are required changes for running with nc-multiplex on digital ocean, where the shell PATH and build requirements dictate this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way that
npm run devandnpm run packagework due to differences in our MacOS shell environment and Digital Ocean's environment../@build-ursys.shbecause./isn't included in the path by default, as it is in our VSCode integrated terminal./@build-ursys.shbecause it was not being run at all, causing a potential failure to load in net graphs because the libraries were not built.See issue #234 for details.
TECHNICAL NOTES
On Digital Ocean running nc-multiplex, the installation instructions call for running
npm run packageonce after doing a pull of thenetcreate-itestrepo. This is to ensure that all built libraries are available, asnc-multiplexdoes not do it automatically. Up to now,npm run packagedid not build the ursys libraries asnpm run devdoes automatically. This can cause URSYS versions to not be available (showing load errors in the javascript console) or cause URSYS versions to be out-of-date.NetCreate makes fairly minimum use of URSYS itself with the exception of the "Comments" addon, but the libraries must be present for the app to load.