forked from netcreateorg/netcreate-2018
-
Notifications
You must be signed in to change notification settings - Fork 1
Feature: Provenance #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature: Provenance #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match MEME
Rather than show complex "DELETED" for every prompt in a comment type because there may be many.
…when updating comment status.
…t` to TCommentCollection
# Conflicts: # app/view/netcreate/components/NCEdgeTable.jsx # app/view/netcreate/components/NCNodeTable.jsx
… have not been defined.
…s implementation in MEME)
…s updated when Node selection is switched
…to use URCommentVBtn (and URCommentCollectionMgr)
…ment.id` to match pmcData
…for URCommentCollectionMgr calls.
…d directly by URCommentVBtn but we might want to restore this to force close the currently open comment window and re-open the table comment button
…l components. Simplify URDATA handlers." "SELECTION" and "HILITE" are not yet implemented.
…te, then dc-comments.DEFAULT_CommentTypes then fall back to DEFAULT_COMMENTTYPE #244
… edge "info/Date" doesn't refer to mismatched date/number
…e.css not NCNode.css.
… Fixes Edge table breaking upon creating a new edge.
…an Edge Edit will not delete the edge. #330.
…emplate-defined sort types where appropriate, but also override for styling. created and updated use `timestamp-short`. createdBy and updatedBy use `text-case-insensitive`
Merged
|
For the record...this branch/PR was successfully used with the Jan 15 IU pilot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for provenance:
isProvenanceflag.hiddenproperty as any non-built-in field does (e.g. can be hidden, and will not be exported when hidden).infoOriginthat initially displaysCreated by <createdBy> on <created>but then operates as string field. It can be used outside of the "Provenance" section if you want.createdorupdatedare hidden (respectively), but will still be exported and imported because they are built-in fields.createdByandupdatedBycan be selectively hidden so that the History will hide author info and only show "Created: 1/7/2025, 10:05:37 AM" or "Updated: 1/7/2025, 10:05:37 AM".TBD
See also #55, #275, #276
Wiki
(To be added with PR)
infoOriginfieldinfoOriginis a special field. Initially the value will be set toCreated by <createdby> on <created>, but upon editing it behaves like a string field so you can edit the field to say anything you want. Once you edit the field, the field behaves like a string field.infoOriginhonors bothisProvenanceandhiddenparameters.Provenance Tab
Adding fields to the "Provenance" section
In project templates, use
isProvenance = trueto add a field to the Provenance Section of a Node or Edge Editor. Any field type can be supported."History" section
The "History" section of the tab uses five built-in fields:
created-- date of creationcreatedby-- token of user who created the objectupdated-- date of update of the objectupdatedby-- token of user who updated the objectrevision-- a count of the number of times the object has been revised.The "History" shows a combination of fields:
createdby+createdupatedby+updatedhiddenparameterThe history fields may be hidden in the Node/Edge Editors and Tables by using
hidden = true, but they will always be exported and imported.createdis hidden, then the whole "Created: , " line is hidden.createdbyis hidden, then only the user is hidden, e.g. the line will display "Created: "updatedandupdatedbywork the same way.isProvenanceparameterThe "History" section ignores the
isProvenance = trueflag. It is a built-in field that will always be placed in the "History" section (as long as it's not hidden).timestampfield filteringSince we do not have a specialized UI for setting time and date (e.g. you can't select a particular day or year or time), we rely on the Historical Date functionality to provide a UI for specifying a filter string. e.g. you can search by using: