Settings Infrastructure Progress #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aceholder comment
…tting values writing
…et(), not await Get()
context exists only inside the rendering function
…prop-settings # Conflicts: # app/view/netcreate/components/MURSettingsEditor.jsx
dsriseah
changed the title
|
Confirmed works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR commits the architecture of a new Settings Manager and the underlying MUR subsystem that bridges Typescript to Javascript in the legacy NetCreate development environment. This consists generally of two parts:
After long evaluation, we can't use the new server module because the underlying template data of the legacy code is quite tangled and unstructured. So, instead we will write bridge modules to try to make it work with the new settings UI system.
Note
The newer modularization work isn't lost and will be moved to our next generation URSYS platform for future apps; we need to build a new UI framework with a clean data stack to make use of it. Converting the old to the new would be prohibitively expensive given the number of legacy special cases, and risks stability of the current version.
TESTING
This shouldn't introduce anything other than a slightly different Advanced Settings Panel that doesn't do anything.
This has a TODO LIST and the current SETTING UI that uses newer React Context, which you can use the ShowWIP toggle button in the SETTINGS subtab to see.
There should be no other functional changes to
dev-dhiat the time of this merging SHA 0d2056a