Merge dev-dhi into deploy #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch async bugs in programming see potential bug in server-database in WriteTemplateTOML
…p-compatible data
I'm going to rewrite SettingsContext to hold viewData, not a dictionary of layered properties
next use viewstate as Context and pass dotProp instead of propDefs to subcomponents
# Conflicts: # app/view/netcreate/components/NCAdvancedPanel.jsx
…uscate actual errors
… PropertyGroup, TextInput, and useReducer and useContext the TEMPLATE TOML file now has _ui.propertyName and _ui._editor.global for adding UI metadata to control Settings
I can edit a TextInput, and the state updates from direct input.
…rsist to disk yet
…e, but inputValue has to remain for controlled inputs
fix issue 402, remove unnecessary indirection from async and nested functions
…ip out stuff in to-be-deprecated NCTemplate
removes confusion
…t-settings-bridge also ViewLib since we had to use React components, and the yaml versions of template
…STATE' This is only used by the lockstate manager, and the use of "LOCK" reinforces the model instead of obfuscating it
also cleaned-up most debug output
Settings Progress 2 - Template Edit / Save Proof of Concept
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep
deploybranch up to date with recent PR #406