Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Change Prometheus Exporter Categorizations #1303

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

ralphm
Copy link
Member

@ralphm ralphm commented Aug 1, 2023

No description provided.

@ralphm ralphm requested a review from ilyam8 as a code owner August 1, 2023 16:19
@ilyam8 ilyam8 merged commit fd275a3 into master Aug 1, 2023
@ilyam8 ilyam8 deleted the prometheus-integrations branch August 1, 2023 16:21
@ralphm
Copy link
Member Author

ralphm commented Aug 1, 2023

A few remarks:

  • Why is the GitHub collector in apm, but the GitHub API limit one in generic-data-collection?
  • Is generic-data-collection meant as a catch-all, or specifically for generic collection like StatsD, SNMP, Prometheus?
  • Maybe Cilium Hubble belongs in `networking-stack-and-network-interfaces'
  • MQTT Blackbox: it is now in synthetic-checks, but maybe message-brokers is better?
  • What is the difference between the APM and Observability categories?
  • Why do we have a separate category for Kubernetes, but lump all other container and VM exporters into containers-and-vms?
  • SSH: unsure, but authentication-and-authorization seems off
  • What is the notifications category? It has StatusPage and OTRS. What about Discourse?
  • bfptrace -> linux-systems?
  • AMD CPU & GPU: linux-systems?
  • Zulip is in notifications but XMPP is in message broker. Both are chat systems. Maybe we can lump them together into a Chat category?

@ilyam8
Copy link
Member

ilyam8 commented Aug 1, 2023

cc @shyamvalsan (you added initial categories in #1253)

@shyamvalsan
Copy link
Contributor

@ralphm @ilyam8 The base categories were just using what existed already on the website. And we need to fix stuff for sure.

  • Generic data collection is intended to cover prometheus, statsd, snmp scenarios, where it can be used to collect data from a variety of sources.
  • GitHub and GitHub API should both be somewhere else
  • If we need a catch all, it should be "Other"
  • I think @sashwathn already moved MQTT blackbox to message-brokers, PR pending
  • Obervability is just about monitoring observability services
  • Kubernetes vs Containers & VMs (I think the ask for a separate category for Kubernetes is from @ktsaou, we're just following the precedence from the website here)
  • The notifications category has been renamed by @sashwathn to "Notifications and Incident Management" - not sure Discourse fits in either way

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants