Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to makefiles while building #242

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

UmanShahzad
Copy link
Contributor

While building this for the first time, I ran into some issues, and fixed stuff on the way.

@UmanShahzad UmanShahzad requested a review from thiagoftsm July 15, 2021 13:03
@UmanShahzad UmanShahzad requested a review from Ferroin as a code owner July 15, 2021 13:03
@thiagoftsm
Copy link
Contributor

@UmanShahzad I did not understand the empty tools/complement.sh, please, take a look on it.

@UmanShahzad
Copy link
Contributor Author

@thiagoftsm it is only changing the permission to make it executable.

Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @UmanShahzad! LGTM!

@UmanShahzad UmanShahzad merged commit d41e8dd into netdata:master Jul 16, 2021
@UmanShahzad UmanShahzad deleted the makefiles-fixes branch July 16, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants