Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandas collector replace self.warn() with self.warning() #14736

Merged

Conversation

andrewm4894
Copy link
Contributor

@andrewm4894 andrewm4894 commented Mar 15, 2023

Summary

this was a small typo on my end and we should use self.warning() instead of self.warn(). self.warn() throws error and fails the check().

Test Plan

Tested locally on agents where these lines end up being called,

Additional Information
For users: How does this change affect me?

@andrewm4894 andrewm4894 marked this pull request as ready for review March 15, 2023 15:47
@andrewm4894 andrewm4894 requested a review from ilyam8 as a code owner March 15, 2023 15:47
@github-actions github-actions bot added area/collectors Everything related to data collection collectors/python.d labels Mar 15, 2023
@andrewm4894 andrewm4894 merged commit 8c602ff into netdata:master Mar 15, 2023
@andrewm4894 andrewm4894 deleted the pandas-collector-fix-warn-typo branch March 15, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collectors Everything related to data collection collectors/python.d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants