Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve windows agent #18227

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Improve windows agent #18227

merged 6 commits into from
Jul 26, 2024

Conversation

thiagoftsm
Copy link
Contributor

Summary

This PR is bringing two changes for netdata:

Test Plan
  1. Compile on Windows and generate the installer.
  2. Take a look in default path shown.
  3. When installation ends, access /api/v1/info and check your os_id.
Additional Information
For users: How does this change affect me?

@thiagoftsm thiagoftsm requested review from a team and vkalintiris as code owners July 25, 2024 06:31
@thiagoftsm thiagoftsm changed the title Improve win Improve windows agent Jul 25, 2024
@github-actions github-actions bot added area/packaging Packaging and operating systems support area/daemon labels Jul 25, 2024
@thiagoftsm thiagoftsm requested a review from stelfrag July 25, 2024 13:30
@thiagoftsm thiagoftsm merged commit 26d1c19 into netdata:master Jul 26, 2024
141 checks passed
@thiagoftsm thiagoftsm deleted the improve_win branch July 26, 2024 17:40
@thiagoftsm thiagoftsm mentioned this pull request Jul 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stelfrag stelfrag stelfrag approved these changes

@vkalintiris vkalintiris Awaiting requested review from vkalintiris vkalintiris is a code owner

Assignees
No one assigned
Labels
area/daemon area/packaging Packaging and operating systems support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiagoftsm @stelfrag