Cleanup, rename and packaging fix (Windows Codes) #18455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagoftsm
requested review from
vkalintiris,
a team and
Ferroin
as code owners
github-actions
bot
added
area/packaging
thiagoftsm
force-pushed
the
clean_rename
branch
from
67b4fd1 to
73b9f44
Compare
… application 'category'
stelfrag
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is bringing some adjusts we had talked in our meetings.
It also removes unnecessary codes from our CMakelist.txt.
Considering this PR was built on top of #18443, I am going to keep it as draft for while.
Test Plan
Additional Information
For users: How does this change affect me?