Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows.plugin (IIS) #18566

Merged
merged 15 commits into from
Oct 3, 2024
Merged

windows.plugin (IIS) #18566

merged 15 commits into from
Oct 3, 2024

Conversation

thiagoftsm
Copy link
Contributor

@thiagoftsm thiagoftsm commented Sep 17, 2024 •
edited
Loading

Summary

This PR brings IIS metrics to windows.plugin.

Test Plan
  1. Install IIS on your host. If you never had to do this before, you can follow this instructions.
  2. Check if it is running, in theory you will have port 80 open in your host.
  3. Compile this branch
  4. Build the installer
  5. Install netdata. Access the local server, and you should have metrics:

Screenshot_20240918_025259

Additional Information
For users: How does this change affect me?

@thiagoftsm thiagoftsm requested review from vkalintiris and a team as code owners September 17, 2024 06:29
@thiagoftsm thiagoftsm marked this pull request as draft September 17, 2024 06:29
@github-actions github-actions bot added area/collectors Everything related to data collection area/build Build system (autotools and cmake). collectors/windows labels Sep 17, 2024
@thiagoftsm thiagoftsm requested a review from stelfrag September 17, 2024 12:32
@thiagoftsm thiagoftsm marked this pull request as ready for review September 18, 2024 03:06
@thiagoftsm thiagoftsm mentioned this pull request Sep 21, 2024
Merged
@thiagoftsm thiagoftsm force-pushed the iis_metrics branch 2 times, most recently from 77a32d0 to 6381156 Compare September 23, 2024 12:39
@thiagoftsm thiagoftsm mentioned this pull request Sep 23, 2024
Open
12 tasks
@github-actions github-actions bot added the area/metadata Integrations metadata label Sep 25, 2024
@github-actions github-actions bot removed the area/metadata Integrations metadata label Sep 30, 2024
@thiagoftsm thiagoftsm force-pushed the iis_metrics branch 3 times, most recently from 250c9b4 to 6e20cab Compare October 2, 2024 17:00
@thiagoftsm thiagoftsm merged commit 77d0c65 into netdata:master Oct 3, 2024
138 of 140 checks passed
@thiagoftsm thiagoftsm deleted the iis_metrics branch October 3, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stelfrag stelfrag stelfrag approved these changes

@vkalintiris vkalintiris Awaiting requested review from vkalintiris vkalintiris is a code owner

Assignees
No one assigned
Labels
area/build Build system (autotools and cmake). area/collectors Everything related to data collection collectors/windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiagoftsm @stelfrag