Open
Conversation
Contributor
lyjamare
reviewed
Sep 26, 2024
Collaborator
There was a problem hiding this comment.
在 waitThreadWithTimeout 方法中,建议在进入同步块之前检查 timeout 是否有效,以避免不必要的同步开销。
@NaslLogic
public static Boolean waitThreadWithTimeout(String lock, Long timeout) {
if (lock == null) {
log.error("锁对象不能为空");
return false;
}
if (timeout <= 0) {
log.error("超时时间必须大于0");
return false;
}
synchronized (lock.intern()) {
try {
lock.intern().wait(timeout);
log.info("线程在超时前被成功唤醒");
return true;
} catch (InterruptedException e) {
log.error("带超时的等待线程被中断", e);
Thread.currentThread().interrupt();
return false;
}
}
}
Contributor
Contributor
Collaborator
|
功能及代码已验收,待评分 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.