Open
Conversation
Contributor
Contributor
lyjamare
reviewed
Sep 26, 2024
| */ | ||
| @NaslLogic | ||
| public DelayedTask pollWithTimeout(Long timeout) { | ||
| // 检查延迟队列是否已初始化 |
Collaborator
There was a problem hiding this comment.
在每个方法中都检查了 delayQueue 是否已初始化。这虽然是一种安全的做法，但会导致代码重复。可以考虑将这个检查提取到一个私有方法中，以减少代码冗余。
Contributor
Author
There was a problem hiding this comment.
已优化，将这块逻辑封装成了一个私有方法，应用到方法中。
Contributor
Collaborator
|
功能及代码已验收，待评分 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.