Fixed issue ospf gui (Issue #929) #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added default columns to ospfIf in case of missing ospfNbr data, to avoid bad behavior in GUI. Signed-off-by: rickstardust <rick_nan@stardustsystems.net>
rickstardust
changed the title
AndryNick98
requested review from
ddutt,
claudious96,
LucaNicosia and
AndryNick98
ddutt
reviewed
Apr 9, 2024
Signed-off-by: rickstardust <rick_nan@stardustsystems.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported an
AttributeErroroccuring when using the main GUI page when having no OSPF tables.Related Issue
#929
Description
The error originated from the ospf engine: when merging the ospfNbr and ospfIf tables, the code didn't ensure that the schema was correct also in case of missing data.
Type of change
Double Check
developbranch.developbranch.--signoffapplied