fix(adapter-puppeteer): Remove other resource type matching #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmit
force-pushed
the
u/jasonmit/drop-other-from-puppeteer
branch
2 times, most recently
from
263a867
to
18f38ba
Compare
offirgolan
approved these changes
Apr 9, 2019
jasonmit
force-pushed
the
u/jasonmit/drop-other-from-puppeteer
branch
from
18f38ba
to
42ceecb
Compare
jasonmit
force-pushed
the
u/jasonmit/drop-other-from-puppeteer
branch
from
42ceecb
to
1d933fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a change in Puppeteer 1.7 that forced us to start capturing
"other"network requests.This led to proxying requests for requests like favicons. This isn't optimal and thankfully is no longer needed as of Puppeteer >= 1.9.
fixes #149