NGSTACK-492 smoke tests #181

iherak · 2024-03-20T15:46:15Z

Introducing three fairly simple "smoke" tests, this is not much, but infinitely better than what we currently have :)

test that the frontpage loads and has logo
test that the search page loads and has input field for searching
test random 10 link from the frontpage and make sure they load

Further implementation, and even proper behat tests will be needed, but this is a first step at least so we have something covered before deploying.

emodric · 2024-03-21T13:32:07Z

composer.json

+        "phpunit/phpunit": "^9.5",
+        "symfony/browser-kit": "5.4.*",
+        "symfony/css-selector": "5.4.*",
+        "symfony/phpunit-bridge": "^7.0"


Can we use 5.4 of the bridge to be inline with other symfony packages?

Done in 4381f4f

emodric · 2024-03-21T13:32:09Z

composer.json

@@ -66,7 +66,11 @@
        "phpstan/phpstan-strict-rules": "^1.5",
        "phpstan/phpstan-symfony": "^1.3",
        "phpstan/phpstan-doctrine": "^1.3",
-        "php-cs-fixer/shim": "^3.50"
+        "php-cs-fixer/shim": "^3.50",
+        "phpunit/phpunit": "^9.5",


Why not PHPUnit 10? It supports PHP 8.1

As far as I can tell, the symfony does not support v10 yet fully: symfony/symfony#49069

emodric · 2024-03-21T13:33:05Z

config/app/packages/webpack_encore.yaml

+    webpack_encore:
+        builds:
+            # The path where Encore is building the assets - i.e. Encore.setOutputPath()
+            app: '%kernel.project_dir%/public/assets/app/build_dev'


Should we use prod assets in test env to make it a bit faster?

We could - but that would requires us to have prod assets ready - which is not necessary at the time of testing.

Why not? As you said, the point of these is to run them on deploy. Just make sure tests are ran after building the prod assets, no?

If you run them manually, then yes, you have to build the assets yourself, but I don't see it as an issue.

We can do - but it is not straightforward.
The idea was to test before doing anything else during deployment so that if it fails, it fails as early as possible. This would mean moving asset build to the beginning of the deploy process, and having to split it into two parts - as right now asset build and copy to prod are bundled together.
It does not seem to me this brings significant performance boost as it is now, but if you'd like, I can make those changes.

No need, it was just an idea.

Maybe later, when and if we have a significant number of tests and if it proves to be a bottleneck.

emodric · 2024-03-21T13:34:36Z

symfony.lock

@@ -1,4 +1,61 @@
 {
+    "babdev/pagerfanta-bundle": {


This needs to be removed from the diff. Only a subset of symfony.lock is added to this repo in order not to disable fetching latest recipes for each of the new projects.

The subset which is commited is related to keeping the structure of the project inline with ibexa, without Flex interfering with it.

Removed in 4c47cd

emodric · 2024-03-21T13:35:35Z

tests/SmokeTests/CrawlerTest.php

+
+        foreach($selectedLinkIndices as $index) {
+            $link = $frontpageLinks[$index];
+            fwrite(STDERR, print_r($link->getUri() . PHP_EOL, TRUE));


Can we use Symfony console here? Or see if PHPUnit has it's own output writer?

Does not seem that PHPUnit has anything, but changed to symfony output in 25ea341

emodric · 2024-03-21T13:36:31Z

tests/SmokeTests/ProjectWebTestCase.php

+    {
+        $client = parent::createClient($options, $server);
+
+        $server['HTTP_HOST'] = static::getContainer()->getParameter('app.testing.site_domain');


Where does this parameter come from?

Finished the implementation in c892c41
Deployer now runs multiple times, for all configured domains:

➤ Executing task app:test:phpunit [localhost] > TEST_DOMAIN=media-site.dev.php81.ez /usr/bin/env php8.1 vendor/bin/phpunit [localhost] < PHPUnit 9.6.18 by Sebastian Bergmann and contributors. [localhost] < Testing [localhost] < Test page: http://media-site.dev.php81.ez/bold_eng/careers?nekisufiks [localhost] < Test page: http://media-site.dev.php81.ez/fh_eng/recipes/greek-quinoa-salad [localhost] < Test page: http://media-site.dev.php81.ez/fh_eng/fitness/effects-of-cadence-training-on-running-biomechanics-and-efficiency [localhost] < . [localhost] < . [localhost] < . 3 / 3 (100%) [localhost] < Time: 00:02.830, Memory: 237.23 MB [localhost] < OK (3 tests, 9 assertions) [localhost] < Remaining self deprecation notices (1) [localhost] < Remaining indirect deprecation notices (437) [localhost] < Other deprecation notices (66) [localhost] > TEST_DOMAIN=media-site.dev.php81.ez/bold_eng /usr/bin/env php8.1 vendor/bin/phpunit [localhost] < PHPUnit 9.6.18 by Sebastian Bergmann and contributors. [localhost] < Testing [localhost] < Test page: http://media-site.dev.php81.ez/bold_eng/# [localhost] < Test page: http://media-site.dev.php81.ez/bold_eng/services [localhost] < Test page: http://media-site.dev.php81.ez/bold_eng/services [localhost] < . [localhost] < . [localhost] < . 3 / 3 (100%) [localhost] < Time: 00:01.986, Memory: 209.23 MB [localhost] < OK (3 tests, 9 assertions) [localhost] < Remaining self deprecation notices (1) [localhost] < Remaining indirect deprecation notices (418) [localhost] < Other deprecation notices (66) • done on [prod] ✔ Ok [5s 33ms]

iherak · 2024-03-25T16:08:29Z

All comments have been addressed I believe.

emodric · 2024-03-25T16:24:50Z

Thanks @iherak !

iherak added 4 commits March 20, 2024 16:11

NGSTACK-492 introduce simple smoke tests

5d05645

NGSTACK-492 introduce project web test case class

4fad093

NGSTACK-492 get domain from parameters

13f6a36

NGSTACK-492 add tests to deploy procedure

f09d65f

iherak requested a review from emodric March 20, 2024 15:46

emodric reviewed Mar 21, 2024

View reviewed changes

iherak added 4 commits March 25, 2024 15:15

NGSTACK-492 restrict phpunit-brige to 5.4

4381f4f

NGSTACK-492 remove packages from symfony.lock

4c47cdd

NGSTACK-492 use symfony output while testing

25ea341

NGSTACK-492 test multiple configured domains

c892c41

emodric merged commit 9519c17 into master Mar 25, 2024

iherak deleted the NGSTACK-492-smoke-tests branch May 7, 2024 13:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NGSTACK-492 smoke tests #181

NGSTACK-492 smoke tests #181

iherak commented Mar 20, 2024

emodric Mar 21, 2024

iherak Mar 25, 2024

emodric Mar 21, 2024 •

edited

Loading

iherak Mar 25, 2024

emodric Mar 25, 2024

emodric Mar 21, 2024

iherak Mar 25, 2024

emodric Mar 25, 2024

iherak Mar 25, 2024

emodric Mar 25, 2024 •

edited

Loading

emodric Mar 21, 2024

iherak Mar 25, 2024

emodric Mar 21, 2024

iherak Mar 25, 2024

emodric Mar 21, 2024

iherak Mar 25, 2024

iherak commented Mar 25, 2024 •

edited

Loading

emodric commented Mar 25, 2024

NGSTACK-492 smoke tests #181

NGSTACK-492 smoke tests #181

Conversation

iherak commented Mar 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emodric Mar 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emodric Mar 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iherak commented Mar 25, 2024 • edited Loading

emodric commented Mar 25, 2024

emodric Mar 21, 2024 •

edited

Loading

emodric Mar 25, 2024 •

edited

Loading

iherak commented Mar 25, 2024 •

edited

Loading