Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Boolean Predicates #18

Merged
merged 3 commits into from
May 25, 2020
Merged

Fix Boolean Predicates #18

merged 3 commits into from
May 25, 2020

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented May 25, 2020

Fixes #17 by serializing a boolean argument to 'true' or 'false' during query preparation in SimplePredicate

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #18 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #18   +/-   ##
=========================================
  Coverage     98.36%   98.37%           
- Complexity      860      862    +2     
=========================================
  Files            42       42           
  Lines          1778     1780    +2     
=========================================
+ Hits           1749     1751    +2     
  Misses           29       29           
Impacted Files Coverage Δ Complexity Δ
src/Prismic/SimplePredicate.php 100.00% <100.00%> (ø) 10.00 <0.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e0682...5efc11a. Read the comment docs.

@gsteel gsteel merged commit ad4484c into master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query Predicates for Booleans are likely broken
1 participant