Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added boolean field-type. #8

Closed
wants to merge 2 commits into from
Closed

Added boolean field-type. #8

wants to merge 2 commits into from

Conversation

into-the-v0id
Copy link

Here a PR to fix #7

Unfortunately I am not able to provide tests at the moment.

@into-the-v0id
Copy link
Author

No feedback?

@gsteel gsteel self-requested a review March 12, 2020 14:36
@gsteel gsteel mentioned this pull request Mar 12, 2020
@gsteel gsteel closed this in #9 Mar 12, 2020
@into-the-v0id into-the-v0id deleted the boolean-field branch March 14, 2020 09:36
@into-the-v0id
Copy link
Author

Thanks :)

@gsteel
Copy link
Member

gsteel commented Mar 18, 2020

Thanks to you @into-the-v0id for spotting it and kicking off the pull. I'd be interested to hear your experiences of using the lib. I have some BC breaking plans I'm working on to separate out HTML serialisation into standalone and replaceable serialisers that should make the lib cleaner, more flexible and easier to test. There's some work already on master and in some other pushed branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean field causes error
2 participants