Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the crownlabs-image-list folder and generalize the pipelines #350

Merged
merged 4 commits into from
Nov 24, 2020
Merged

Refactor the crownlabs-image-list folder and generalize the pipelines #350

merged 4 commits into from
Nov 24, 2020

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Nov 23, 2020 •
edited
Loading

Description

This PR continues along the direction of #343 to refactor the operators folder.

  • Updates and moves the different components of crownlabs-image-list to the correct folder.
  • Generalizes the build pipeline to build multiple operators at the same time.
  • Adds a python linter to ensure consistency in the python code

How Has This Been Tested?

  • Checking the outcome of the pipelines
  • Manual testing

@giorio94 giorio94 force-pushed the mio/image-lists branch 2 times, most recently from 2edbfd0 to f43bb56 Compare November 23, 2020 17:18
@giorio94 giorio94 marked this pull request as ready for review November 23, 2020 17:23
GabriFila
GabriFila approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@GabriFila GabriFila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@giorio94
Copy link
Member Author

/rebase

@giorio94
Copy link
Member Author

/merge

@kingmakerbot kingmakerbot merged commit a24ba93 into master Nov 24, 2020
@kingmakerbot kingmakerbot deleted the mio/image-lists branch November 24, 2020 19:29
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

@giorio94 giorio94 added the kind/cleanup Refactoring code label Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabriFila GabriFila GabriFila approved these changes

@palexster palexster palexster approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code sig/api sig/devops sig/operations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giorio94 @kingmakerbot @palexster @GabriFila