Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keycloak functionalities to Workspace resource #368

Merged
merged 3 commits into from
Dec 11, 2020
Merged

Add keycloak functionalities to Workspace resource #368

merged 3 commits into from
Dec 11, 2020

Conversation

GabriFila
Copy link
Contributor

@GabriFila GabriFila commented Dec 9, 2020 •
edited
Loading

Description

This PR includes:

  • simple refactoring by removing kubebuilder leftovers and naming/logging imprecisions
  • added keycloak functionalities for workspaces (creation/deletion of roles)
  • added dockerfile for deployment
  • added k8s manifest

A single replica is ok for this operator? Do I need to set it as a variable in the template?

How Has This Been Tested?

I added the tests for the keycloak functionalities using mocks with gomock. At the moment the only case tested is the successful one and the role already existed in keycloak. Other cases can be added in the future.

@kingmakerbot
Copy link
Collaborator

Hi @GabriFila. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@GabriFila GabriFila force-pushed the gbf/tenant_workspace branch from 7af350a to ce87437 Compare December 9, 2020 17:36
@GabriFila GabriFila changed the title Gbf/tenant workspace Add keycloak functionalities to Workspace resource Dec 9, 2020
@GabriFila GabriFila force-pushed the gbf/tenant_workspace branch 3 times, most recently from 3c0c6ff to 976ce5f Compare December 9, 2020 22:45
@GabriFila GabriFila force-pushed the gbf/tenant_workspace branch 2 times, most recently from e052b7c to 72ce64b Compare December 10, 2020 08:31
@GabriFila GabriFila added the kind/feature New feature or request label Dec 10, 2020
@GabriFila GabriFila marked this pull request as ready for review December 10, 2020 08:52
giorio94
giorio94 reviewed Dec 10, 2020
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @GabriFila!

Some random comments here and there

operators/cmd/tenant-operator/main.go Outdated Show resolved Hide resolved
operators/cmd/tenant-operator/main.go Outdated Show resolved Hide resolved
operators/deploy/tenant-operator/k8s-cluster-role.yaml Outdated Show resolved Hide resolved
operators/deploy/tenant-operator/k8s-cluster-role.yaml Outdated Show resolved Hide resolved
operators/deploy/tenant-operator/k8s-manifest.yaml.tmpl Outdated Show resolved Hide resolved
operators/pkg/controllers/workspace_controller.go Outdated Show resolved Hide resolved
operators/pkg/controllers/workspace_controller.go Outdated Show resolved Hide resolved
operators/pkg/controllers/workspace_controller_test.go Outdated Show resolved Hide resolved
operators/Makefile Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@GabriFila GabriFila force-pushed the gbf/tenant_workspace branch from 72ce64b to f50cbc2 Compare December 10, 2020 13:37
@GabriFila GabriFila force-pushed the gbf/tenant_workspace branch from f50cbc2 to cab0ba4 Compare December 10, 2020 16:31
@GabriFila GabriFila added the hold Prevent bot merging label Dec 10, 2020
@GabriFila GabriFila force-pushed the gbf/tenant_workspace branch from cab0ba4 to 001b4f2 Compare December 10, 2020 18:22
@GabriFila GabriFila removed the hold Prevent bot merging label Dec 10, 2020
@GabriFila
Copy link
Contributor Author

/merge

@kingmakerbot kingmakerbot merged commit a1c0466 into master Dec 11, 2020
@kingmakerbot kingmakerbot deleted the gbf/tenant_workspace branch December 11, 2020 08:18
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorio94 giorio94 giorio94 approved these changes

@palexster palexster palexster approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request sig/api sig/devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GabriFila @kingmakerbot @palexster @giorio94