Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build pipeline: better matrix names #369

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Conversation

giorio94
Copy link
Member

Description

This PR introduces a bit of code duplication in the build pipeline to improve the names of the resulting checks.
Let me know whether you prefer the previous or the current solution.

How Has This Been Tested?

Checking the outcome of the pipelines

@kingmakerbot
Copy link
Collaborator

Hi @giorio94. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giorio94 giorio94 marked this pull request as ready for review December 10, 2020 08:49
@giorio94 giorio94 requested a review from GabriFila December 10, 2020 08:50
Copy link
Contributor

@GabriFila GabriFila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@palexster
Copy link
Member

/merge

@kingmakerbot kingmakerbot merged commit 9aa16da into master Dec 10, 2020
@kingmakerbot kingmakerbot deleted the mio/build-pipeline branch December 10, 2020 14:05
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

@giorio94 giorio94 added the kind/cleanup Refactoring code label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants