Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First deployable version of tenant controller #383

Merged
merged 7 commits into from
Dec 28, 2020

Conversation

GabriFila
Copy link
Contributor

Description

This PR includes:

  • management of inconsistent workspaces, by adding the field inconsistenWorkspaces to the status of the tenant
  • allows for the automatic unsubscription of a tenant from a workspace when the latter gets deleted
  • adds automatic generation of the needed Kubernetes resources to allow the correct consumption of templates and instances
  • renames the admin concept to powerUser
  • adds a description equal to the pretty name of a workspace for better visualization in keycloak

How Has This Been Tested?

At the current state, this PR doesn't add the proper testing, just the minimum for the test to run properly

@kingmakerbot
Copy link
Collaborator

Hi @GabriFila. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@GabriFila GabriFila force-pushed the gbf/tenant_workspace branch from 3e5bb70 to 809f2ec Compare December 26, 2020 18:20
@frisso
Copy link
Member

frisso commented Dec 27, 2020

Gabriele, this PR looks great!
I would suggest to document a little bit more what you intent with "inconsistent" workspace, which does not look obvious to me.

@GabriFila GabriFila force-pushed the gbf/tenant_workspace branch from 809f2ec to 28a20c6 Compare December 27, 2020 20:46
@giorio94 giorio94 added the kind/feature New feature or request label Dec 28, 2020
@GabriFila GabriFila force-pushed the gbf/tenant_workspace branch from 28a20c6 to dbedf05 Compare December 28, 2020 13:07
@GabriFila GabriFila force-pushed the gbf/tenant_workspace branch from dbedf05 to 04b4aaf Compare December 28, 2020 13:19
@GabriFila GabriFila force-pushed the gbf/tenant_workspace branch from 04b4aaf to 3671afa Compare December 28, 2020 13:46
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@GabriFila GabriFila marked this pull request as ready for review December 28, 2020 13:47
@GabriFila GabriFila changed the title Gbf/tenant workspace First deployable version of tenant controller Dec 28, 2020
@giorio94
Copy link
Member

/merge

@kingmakerbot kingmakerbot merged commit 8b85222 into master Dec 28, 2020
@kingmakerbot kingmakerbot deleted the gbf/tenant_workspace branch December 28, 2020 13:58
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants