Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment issues in tenant operator #386

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Conversation

GabriFila
Copy link
Contributor

Description

This PR fixes two minor issues in the deployment for the tenant controller

@kingmakerbot
Copy link
Collaborator

Hi @GabriFila. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@GabriFila GabriFila force-pushed the gbf/tenant_workspace branch 2 times, most recently from ef41d29 to ffd48fa Compare December 28, 2020 16:59
@GabriFila GabriFila force-pushed the gbf/tenant_workspace branch from ffd48fa to ac5ab78 Compare December 28, 2020 17:10
@GabriFila GabriFila force-pushed the gbf/tenant_workspace branch from ac5ab78 to 7e1148b Compare December 28, 2020 17:11
@giorio94
Copy link
Member

/merge

@kingmakerbot kingmakerbot merged commit 4b59167 into master Dec 28, 2020
@kingmakerbot kingmakerbot deleted the gbf/tenant_workspace branch December 28, 2020 17:15
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

@giorio94 giorio94 added the kind/bug Something isn't working label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working sig/api size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants