Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply kube-score to the rendered manifests #395

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Apply kube-score to the rendered manifests #395

merged 2 commits into from
Jan 13, 2021

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Jan 7, 2021 •
edited
Loading

Description

This PR updates the kube-score check, to apply it to the rendered manifests instead of the old ones.
The pull_request_target check fails, since it is still operating on the old files that have been deleted.

@kingmakerbot
Copy link
Collaborator

Hi @giorio94. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giorio94 giorio94 force-pushed the mio/kube-score branch 3 times, most recently from 6f62029 to a08d6cc Compare January 10, 2021 13:58
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 10, 2021
@giorio94 giorio94 added the kind/cleanup Refactoring code label Jan 12, 2021
@giorio94
Copy link
Member Author

/rebase

@giorio94 giorio94 marked this pull request as ready for review January 12, 2021 13:25
GabriFila
GabriFila approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@GabriFila GabriFila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@giorio94
Copy link
Member Author

/merge

@kingmakerbot kingmakerbot merged commit cc8f2df into master Jan 13, 2021
@kingmakerbot kingmakerbot deleted the mio/kube-score branch January 13, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabriFila GabriFila GabriFila approved these changes

@palexster palexster palexster approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code sig/api sig/devops size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giorio94 @kingmakerbot @palexster @GabriFila