-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tenant operator: fix nextcloud secret issue #410
Conversation
Hi @giorio94. Thanks for your PR. I am @kingmakerbot.
Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:
|
/deploy-staging |
Your staging environment has been correctly deployed/updated!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a way to test it? I think it could be useful to protect it.
/hold I will try to add an appropriate test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
4acb025
to
9604c05
Compare
/unhold |
/merge |
Your staging environment has been correctly teared-down! |
Description
This PR fixes the creation of the secret containing the nextcloud credentials, avoiding to apply the base64 enconding. Additionally, it introduces a new test ensuring the correctness of the secret creation.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.