Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenant operator: fix nextcloud secret issue #410

Merged
merged 1 commit into from
Jan 30, 2021

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Jan 30, 2021

Description

This PR fixes the creation of the secret containing the nextcloud credentials, avoiding to apply the base64 enconding. Additionally, it introduces a new test ensuring the correctness of the secret creation.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Ginkgo test
  • Staging environment

@giorio94 giorio94 added kind/bug Something isn't working and removed size/XS labels Jan 30, 2021
@kingmakerbot
Copy link
Collaborator

Hi @giorio94. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giorio94
Copy link
Member Author

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!

@giorio94 giorio94 marked this pull request as ready for review January 30, 2021 08:05
Copy link
Member

@palexster palexster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a way to test it? I think it could be useful to protect it.

@giorio94
Copy link
Member Author

/hold

I will try to add an appropriate test

@kingmakerbot kingmakerbot added the hold Prevent bot merging label Jan 30, 2021
Copy link
Contributor

@GabriFila GabriFila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@giorio94 giorio94 force-pushed the mio/tenat-nextcloud-secret branch from 4acb025 to 9604c05 Compare January 30, 2021 10:42
@giorio94
Copy link
Member Author

/unhold

@kingmakerbot kingmakerbot removed the hold Prevent bot merging label Jan 30, 2021
@giorio94
Copy link
Member Author

/merge

@kingmakerbot kingmakerbot merged commit 2710eea into master Jan 30, 2021
@kingmakerbot kingmakerbot deleted the mio/tenat-nextcloud-secret branch January 30, 2021 10:54
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working sig/api size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants